Anton Banchev

Results 6 issues of Anton Banchev

The progress tracker gives just the file name and not the path, so if we have sub folders with similarly named files we cannot track the percentage state of the...

When trying to upload a folder that has a big (2.7gb) video i get an error ``` Err File size (2761104038) is greater than possible Buffer: 2147483647 bytes ``` I...

if we sync a folder, and then reuse the instance of the object to upload a new one transferredFileCount does not reset to 0, just keeps increasing.

PR welcome

There is no way to dispose of a connection when cleaning up after a upload

The permissions changed, the api should reflect the breaking changes https://developers.binance.com/docs/binance-spot-api-docs/CHANGELOG

review

https://github.com/binance/binance-connector-typescript/blob/8d3267389f9cff96863dac09bbee77514ea153ed/src/websocketStream.ts#L23 string.replace replaces only the first occurence of a symbol, so `sub1,sub2,sub3,sub4` will incorrectly be changed to `sub1/sub2,sub3,sub4` Better alternative is ``` if (Array.isArray(stream)) stream = stream.join("/"); ```

review