Aymeric Augustin

Results 368 comments of Aymeric Augustin

That's an interesting behavior that I wasn't aware of. Let me reconsider.

On Google Cloud Run, using an HTTP probe is cleaner: - https://cloud.google.com/run/docs/samples/cloudrun-healthchecks-liveness-probe-http - https://websockets.readthedocs.io/en/stable/faq/server.html#how-do-i-implement-a-health-check

You're referring to an application-level keepalive, not protocol-level, and websockets doesn't provide that. This question comes up regularly; I'll explain in the documentation.

@agronholm The Assembler is an implementation detail: it isn't documented in the API. It could live in the connection module. It happens to be an independent piece with medium complexity,...

websockets got [its own async test harness](https://github.com/python-websockets/websockets/blob/1c8032acb16b2de9d3a63a747eb0ee15feffb41d/tests/legacy/utils.py#L9) before there was one in the stdlib. The legacy implementation still uses it. I switched to `unittest.IsolatedAsyncioTestCase` in the new asyncio implementation. I...

Mastery of pytest isn't the problem. I used it in a professional context before. I know how to configure it. Actually, I spent a lot more time [deep in the...

Short, directional answer because it's 11:30pm here: - I don't see myself reviewing a PR adding an entire implementation. There's a lot of details to get right; I find it...

Indeed, if I finish the trio implementation within a reasonable timeframe, there's little point in an anyio implementation. As all things open-source, completion is highly dependent on everything else in...