Aymeric Augustin

Results 368 comments of Aymeric Augustin

This has to do with how uvicorn embeds websockets. It was integrated before I provided a good API for that use case — namely the Sans-I/O implementation. It's done by...

PS: I don't know if that's the explanation of the first report; I never got details on that one. It's the explanation of the second report, where I have a...

The change causes tests to hang -- because you removed the code paths that manages the end of a connection. The issue looks legit but that's not the right fix.

It is indeed aimed at providing an asyncio implementation on top of the Sans-I/O implementation. Based on my experience of the threading implementation, ETA for completion is likely to be...

I understand your use case and, indeed, you cannot do this with the current API. For receiving frames, it would mean an API like `websocket.recv(decode_text_frames=False)`. (Naming TBC.) Can you confirm...

Yes, we need to pick the names for both sides carefully and, ideally, consistently. `raw_utf8` is a name that could work for both sides. I'm not sure it's the best...

This will be added as part of the new asyncio implementation (#1332).

The new asyncio implementations supports `recv(decode=False)`, which is the original request here. (Also `recv(decode=True)` for the opposite behavior.) I'm not planning to work on the other features discussed above, notably...

I completed your example as follows: ```python #!/usr/bin/env python import asyncio import websockets async def connection(ws): await asyncio.sleep(1) await ws.send("it works") async def process_request(path, headers): return (200, [], b"Hello, world")...