Aatif Syed
Aatif Syed
- [x] remove the `atty` crate in favour of [`IsTerminal`](https://doc.rust-lang.org/std/io/trait.IsTerminal.html) - [x] standardize on the indicatif/dialoguer UI crates - [ ] remove home-rolled `prompt_confirm` function - > Also, as far...
> Oh, and let's reset the `yarn.lock` file. _Originally posted by @lemmih in https://github.com/ChainSafe/forest/pull/2821#pullrequestreview-1412302970_ Some users can't run `yarn install --immutable && yarn run prettier **/*.md --write` without dirtying their...
Maybe one day we can get a track like _0-to-filecoin_ with _select_ materials like: - What is a blockchain? - What is IPFS? - What is filecoin (and how does...
Yes, this is a bit harsh. On the other hand we should have a way to catch panics. Right not as far as I understand, we catch panics only in...
#4143 Semi-automated with https://github.com/aatifsyed/synsert/blob/5f7d39c1ff1ae47d2b028b045378197036a71fa1/examples/tracing.rs ## Change checklist - [x] I have performed a self-review of my own code, - [ ] I have made corresponding changes to the documentation, -...
- We should have one struct where forest environment variables are described (for end users) and accessed (in code) - Remove `documentation/src/environment_variables.md`, and have it link to the rustdoc for...
Before: https://github.com/ChainSafe/forest/blob/9e3ed095a32d14a293ce7ed7b52b48d74d3b67b3/src/chain/store/chain_store.rs#L221 After: ```rust info!(epoch = %ts.epoch(), key = %ts.key(), "new heaviest tipset"); ``` Before: https://github.com/ChainSafe/forest/blob/9e3ed095a32d14a293ce7ed7b52b48d74d3b67b3/src/rpc/channel.rs#L360 After: ```rust tracing::error!(?e, "Failed to serialize channel message"); ``` # Plan - refactor all...
a bunch of the state manager methods have this receiver, but it's not needed
If we have documentation that says > run > `forest-cli tool api-compare` then we should check that we don't regress it
- [ ] Fuzz Forest's open ports - [ ] Forest has processing limits - [ ] Forest has a bug bounty program - [ ] Forest has auditing (procedures)