forest icon indicating copy to clipboard operation
forest copied to clipboard

refactor: use tracing's structured logging

Open aatifsyed opened this issue 1 year ago • 2 comments

#4143

Semi-automated with https://github.com/aatifsyed/synsert/blob/5f7d39c1ff1ae47d2b028b045378197036a71fa1/examples/tracing.rs

Change checklist

  • [x] I have performed a self-review of my own code,
  • [ ] I have made corresponding changes to the documentation,
  • [ ] I have added tests that prove my fix is effective or that my feature works (if possible),
  • [ ] I have made sure the CHANGELOG is up-to-date. All user-facing changes should be reflected in this document.

aatifsyed avatar Apr 10 '24 09:04 aatifsyed

$ git diff main | cat | rg '@@' | wc -l
182

So many call sites

aatifsyed avatar Apr 10 '24 16:04 aatifsyed

I'll look into tracing docs and get back to you here.

LesnyRumcajs avatar Apr 11 '24 09:04 LesnyRumcajs

@aatifsyed what do we do with this draft?

LesnyRumcajs avatar Jul 19 '24 08:07 LesnyRumcajs