Jacob

Results 233 comments of Jacob

I didn't notice the `.decoration` part to be honest. I think a simple api could look like this: ```ts yield* code().highlight.selection(range(0, 0, 0, 10), 2); ``` Where `highlight` is a...

I agree the name choice may not be the best. My general reasoning was that `make` turns something into another thing (as in "make it into something"), while `create` creates...

If you're interested, we now have [project variables](https://motion-canvas.github.io/docs/project-variables) that let you customize the animation after it was embedded. You could use that to add a select on the documentation page...

Thanks for the PR! Let me know if you're interested in my comment above.

I'd consider whether the additional Signal Context class is necessary, the same can be written using basic signals: ```ts protected readonly inheritedFontSize: () => number; public constructor(props: LayoutProps) { const...

On a separate note: `customX` and `customY` work slightly differently - they are used depending on whether the node is part of a layout. You can't use them to override...

Maybe we could expand the base signal by adding a helper method, then it would be: ```ts @computed() protected applyFont() { this.element.style.fontSize = this.fontSize.context.equals(this.inheritedFontSize) ? '' : this.parsePixels(this.fontSize(); } ```...

Having a default computed value is a good point. But I think that to achieve this we should update the current `signal` decorator to look for `compute[Property]`. (As you probably...