Jacob

Results 233 comments of Jacob

Thanks! To address your comments that I missed before: > does the name have to be identical? If the pr closes an issue, the commit should contain this in its...

Rendering will always get stuck when using `ui:serve` because there's no backend in place to handle the export. `playback.recalculate()` should be called in the `run` method, after `reloadScenes`.

Proposals like this should be done via issues and not PRs: https://github.com/motion-canvas/motion-canvas/blob/main/CONTRIBUTING.md#proposing-a-change Instead of introducing a set of new methods, it would be better to extend the existing `add`, `sub`,...

Awesome, thanks for the PR!

I agree that it's worth expanding the *Flow* guide with these. The cursed snippet should go to the *Threading* guide (which doesn't exist yet but this is where `join`, `cancel`,...

I made #484 for the *Threading* guide

I think it's a good idea. It could be added as an additional option in the Video Settings. Required steps: - [ ] add a new option to the *Video...