Aaron Janse
Aaron Janse
> I think splitting this into multiple commits or suggesting where to start when reviewing might help :) Oh definitely. For this PR, I recommend focusing on mostly the description....
Also to clarify, I don't think the code itself is ready to be merged. But I wanted to make sure we're both on board with the structure before I spend...
>> It uses the gc crate for garbage collection. > > Perhaps I'm missing something obvious, but can you explain, why this is needed? I'm not against it, but I...
Status update: I'm busy for the next few days, but next week I'll submit a PR that does basic arithmetic. I think that should be more helpful for discussion than...
Thank you for the Nix expression! :-) That'll make things much easier to reproduce, since this seems to be working for me without an issue in my dev environment
Thanks! Would you mind making a PR?
@symphorien Would you mind if I merge in the ExprSources alongside an rnix-parser update in a separate PR? I'd put all your edits in a commit, with you marked as...
I like these changes. Thank you @nrdxp! I also agree with @Ma27's feedback :-)
Also, I'm willing to fix the merge conflict while merging this PR, rather than making @nrdxp fix it (unless they want to)
I had the wrong repo open while creating this issue, so I've transferred it here from rnix-parser :facepalm: