rnix-lsp icon indicating copy to clipboard operation
rnix-lsp copied to clipboard

Published 20 hours ago • verified publisher icon nix-community

improved unbound identifier detection

Open symphorien opened this issue 2 years ago • 3 comments

followup to #88

parse all of rnix typed nodes so that unbound identifiers can be detected in much more cases

the evaluation machinery only returns unimplemented for the new nodes

image

at some point I ran rustfmt on the project by habit, I tried to undo some of the changes, but the diff is not minimal.

symphorien avatar Jul 23 '22 20:07 symphorien

@symphorien Would you mind if I merge in the ExprSources alongside an rnix-parser update in a separate PR? I'd put all your edits in a commit, with you marked as the author and me as the committer, so you'd get credit in the Github UI.

Updating rnix-parser would be easier with some of the definitions you added, like StringPartSource.

aaronjanse avatar Jul 29 '22 03:07 aaronjanse

Fine by me as long as it does not create extra merge conflicts, I have a branch with unused binding detection at https://github.com/symphorien/rnix-lsp/tree/unused and it's based on this branch. (will make a PR after some more testing)

symphorien avatar Jul 29 '22 08:07 symphorien

ping @aaronjanse

symphorien avatar Oct 19 '22 15:10 symphorien