Aapo Alasuutari

Results 116 comments of Aapo Alasuutari

I really want to have this feature for FFI callbacks. I'm thinking that perhaps the registered callbacks themselves can be GC'able resources, at which point parsing FFI arguments could be...

Should I add offset parameters to these APIs? I think they'd be useless but it'd then align with the existing APIs. Reasons for uselessness: 1. `getCString`: I would presume any...

> Thanks for the patch @aapoalas - could you add a test? Added a test that verifies both that the `getArrayBuffer` function correctly accesses the expected bytes and that trying...

> If it makes it easier to get a first iteration done here, IMO it's reasonable to just do a swift inlining pass that ignores eluding `unwrapOpResult`. Yeah, I think...

Any idea if this can be merged now or is it still flaking?

I do think we should actually be checking the buffer for size validity. Trying to pass a 0 size buffer as an eg. `["u32"]` struct should error, I think.

Performance implications: Getting the pointer from an `External` takes about 33% more time compared to getting the same pointer from `Number`, at least. If anyone has V8 developers on a...

> Low priority, This will complicate the FFI code for platforms we only theoretically support. Yup, agreed.