Andres Almiray

Indeed. This is the file that javaparser is chocking on at the moment.

There's something odd with the modiTect setup. As far as I can tell from `commons-parent:69` the module name is defined by an expresion `${commons.module.name}` https://github.com/apache/commons-parent/blob/e562e692afef1f6d28cfdd30cd6854c27dba189a/pom.xml#L1839-L1844 https://github.com/apache/commons-parent/blob/e562e692afef1f6d28cfdd30cd6854c27dba189a/pom.xml#L253-L256 Which should make that...

Running the build with `-X` shows the inputs sent to modiTect ``` [DEBUG] Loading mojo org.moditect:moditect-maven-plugin:1.2.1.Final:add-module-info from plugin realm ClassRealm[plugin>org.moditect:moditect-maven-plugin:1.2.1.Final, parent: jdk.internal.loader.ClassLoaders$AppClassLoader@3d71d552] [DEBUG] Configuring mojo execution 'org.moditect:moditect-maven-plugin:1.2.1.Final:add-module-info:add-module-infos' with basic configurator...

Aaand I'm an idiot. The generated `module-info.java` file was created using `jdeps` which takes the module name from the filename. So it's OK. The actual generated `module-info.class` looks like this...

Here's the thing, modiTect could either: 1. Warn if the proposed module name is invalid and bail out 2. Transform the proposed module name to a valid one (when possible),...

The error when copying the JAR is fixed with PR https://github.com/moditect/moditect/pull/246 which is still in review.

@antoinesd PR #246 has been merged. Please rebase and try again with your branch to see if the problem when copying the JAR has indeed gone away. Duplicate modules will...

@antoinesd requested changes only require adding 2 properties to https://github.com/moditect/moditect/blob/main/parent/pom.xml

We may need additional information such as: - JDK used for building - build instructions for HdrHistogram A reproducible setup would be ideal. Also, if you have a look at...

The NPE could be caught and a warning/error could be written out. ModiTect is not supposed to be used with a project that does not produce a JAR.