Blanky

Well , I would like to help in this issue, I am first time contributing here and would appreciate some help.

So like should I wait till the idea is approved right? Meanwhile I can read all the docs and familiarise myself with the environment. I appreciate your help though.

Sorry ,I am kind of busy with my college exams and projects so didnt had much time recently but I would like to start if you okay with it ,...

@rustbot claim

I would like to try fixing this, @Veykril can you please help a little with relevant code and some instruction if possible as it would be my first contribution. I...

> [@BLANKatGITHUB](https://github.com/BLANKatGITHUB) If you want to disable completion inside strings, this should be simple - check if `ctx.original_token` is a string [here](https://github.com/rust-lang/rust-analyzer/blob/ba1c9146fcca65fa9c40d1e4e73bdcb898a8de46/crates/ide-completion/src/lib.rs#L178). Thanks for help but its still kind of...

What do the failed tests print? I kind of implemented `if ctx.original_token == syntax::Syntax::STRING{ return None }` it failed 2 tests now I am trying kind of simple code `...

> I think we need to check if `original_token` and `self_token` (bad name, this is the token in the expansion) here > > [rust-analyzer/crates/ide-completion/src/context/analysis.rs](https://github.com/rust-lang/rust-analyzer/blob/ba1c9146fcca65fa9c40d1e4e73bdcb898a8de46/crates/ide-completion/src/context/analysis.rs#L278-L283) > > Lines 278 to 283...

Umm I added `if (original_token.kind() != self_token.kind()) && (SyntaxKind::is_any_identifier(original_token.kind()) != SyntaxKind::is_any_identifier(self_token.kind())) { return None; }` but it failed some tests 'failures: render::macro_::tests::complete_missing_macro_arg tests::expression::in_macro_expr_frag ' In first step it was unwrapping...

Hi , I am kind of new to open source I would like to help , can you please guide me .