Adedamola Adeniran comments

Results 5 comments of


                                            Adedamola Adeniran

Retrieve request context data through metrics callback

The context is being passed in here https://github.com/cep21/circuit/blob/b244db881625d4706bda7961cf2b5f3c8423985f/v3/circuit.go#L259 The idea is to propagate/extend it to the callbacks

Retrieve request context data through metrics callback

How about introducing additional callbacks that contain the context as one of each callback's parameters? `type RunMetrics interface { Success(context Context, now time.Time, duration time.Duration)` Perhaps, also adding a boolean...

Retrieve request context data through metrics callback

I took some time to go through the code. From my understanding, this can only be done in two ways: - Creating a new version that is not backward compatible...

Retrieve request context data through metrics callback

Also, do you think the other route is acceptable? Will that be accepted as a valid contribution?

Retrieve request context data through metrics callback

Ah I see, seems like a massive duplication but I think it will work.