Andrej Adamcik

@RomainLanz added

@thetutlage yes, that case is working right now. But when you provide custom `client` without setting the transaction on the parent, it doesn't work, the transaction is not being used.

@thetutlage 1. Currently it's allowed to pass custom client via the `options.client`, but it's not working, so it either has to be fixed or removed. 2. We use this a...

@thetutlage Got it, I understand that. However #1096 is not a breaking change and it follows the same convention as other methods on BaseModel like `firstOrCreate`. So it could be...

The pipeline errors do not seem to be related to this PR.

@thetutlage The [`whereIn`](https://github.com/adonisjs/lucid/blob/2d25ef00e53ea179e45ce0c68a00cd0f1d5112b5/src/database/query_builder/chainable.ts#L511) method uses [`transformValue`](https://github.com/adonisjs/lucid/blob/2d25ef00e53ea179e45ce0c68a00cd0f1d5112b5/src/database/query_builder/chainable.ts#L232) that converts `Chainable` using following logic: ```ts if (value instanceof Chainable) { value.applyWhere() return value.knexQuery } ``` So there is `applyConstraints()` missing for relationships....

@thetutlage any luck with testing this? In my opinion, it's important issue and should be fixed. We lost some production data because of this a while ago and had to...

@RomainLanz updated. I had to change transformValue method so drivers get `Date` object instead in queries.

@thetutlage @RomainLanz I managed to get it working for all dialects. The comments are incorporated. However this is not the cleanest solution when it comes to transforming the DateTime values,...

@thetutlage Thank you and fixed! Regarding what I mentioned about transforming values passed to .where() in the last comment, what's the best place to discuss it (if it makes sense...