Aaron Abbott

Results 264 comments of Aaron Abbott

I agree it's cleaner to keep them separate when writing instrumentation. Maybe the logging SDK can provide a means to tie span sampling to event sampling. We have some precedent...

Discussed in SIG and we agreed Logs/events SDK should have way to configure this behavior. Changing to a feature request and I think we may need a spec discussion

Thanks for the PR and apologies no one has take a look yet. First thing before we get too into it–is it possible to sign the CLA? We handle some...

> This was not observed with the gunicorn but when running things with ProcessPoolExecutor which internally uses fork. Ah gotcha. Would it be feasible for you to switch to the...

Got it thanks for looking into this. I feel like we might need to rethink the approach to make things more maintainable and robust. For example I'm not sure if...

Does it work if you swap the order? ```py from opentelemetry.instrumentation.flask import FlaskInstrumentor FlaskInstrumentor().instrument() from flask import Flask # ... ```

Sounds like we can close this then @jeremydvoss ?

> I'm assuming the imports would look something like: > > `from opentelemetry.util._blobupload.api import Blob, BlobUploader, get_blob_uploader` > > I'll confess I'm not terribly familiar with `pyproject.toml` .. any advice...

My main concern with this approach is that the common parts of the config that all tox.ini share may drift over time and become inconsistent or difficult to maintain. For...

> because the order of the tests makes them pass. Is this fixed now?