Aaron Abbott

Results 185 comments of Aaron Abbott

@jeremydvoss somewhat related: https://docs.python.org/3/library/unittest.mock.html#where-to-patch describes monkey patches not taking effect for tests. Looking at the httpx instrumentation code, we are very naiively monkey patching the httpx **module** https://github.com/open-telemetry/opentelemetry-python-contrib/blob/37aba928d45713842941c7efc992726a79ea7d8a/instrumentation/opentelemetry-instrumentation-httpx/src/opentelemetry/instrumentation/httpx/__init__.py#L569-L570 Which means...

Possibly related to https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2364 cc @jeremydvoss > I can add tests with a bit of guidance about where to look/modify/what would be desired. But I'd like to get confirmation that...

Thanks for the PR @samuelcolvin. I did some digging and it looks like the OTel conventions were changed in https://github.com/open-telemetry/semantic-conventions/pull/369 but used to require this normalization. We should definitely fix...

> can we at least run tests, so I know it's passing. Running now > Also, if this won't get merged yet, could we merge #2266 instead first please? There's...

Folks, please see https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2053#issuecomment-1865032194 this is an issue with PyPI. There is nothing we can do. You can install from Git as mentioned in https://github.com/open-telemetry/opentelemetry-python-contrib/issues/2053#issuecomment-1879799993 as a workaround

Thanks @naisanzaa this is real issue. It looks like the subdirectory was deleted in the git repo at the release tag as well. @ocelotl do you remember the context of...

@lzchen to @naisanzaa's point, can we create a public git tag like `aiohttp-server-v0.43b0` at the parent commit (68bea0c10806056d4578446f8cb2167508094a21) so people can install it?

It would be helpful if someone can share a stack trace of what is triggering the log message. OTel SDK components should already be awaiting `waitForAsyncAttributes()` before accessing the resource...

Thanks! We are creating a servicegraph metric in the collector from Beyla spans and I want to resolve the k8s pod name for both `server.address` and `client.address`. One other concern...