Aaron Abbott

Results 185 comments of Aaron Abbott

I don't have time right now if someone else wants to take it

Discuss in SIG. There are a few options: 1. Add a new separate `Tracer.decorate()` decorator that works for both sync and async functions. This is what #3595 currently does 2....

> However, I was wondering if [the API Tracer abstract class](https://github.com/open-telemetry/opentelemetry-python/blob/975733c71473cddddd0859c6fcbd2b02405f7e12/opentelemetry-api/src/opentelemetry/trace/__init__.py#L269) could be implemented by external libraries ? Yes it could be implemented by other SDKs. I'm not aware of...

This seems similar to https://github.com/open-telemetry/opentelemetry-python/issues/3309 when processors or exporters block, we have no way to cancel them.

I think the fix here would be to convert the attribute value to an n-tuple if it is a sequence before calling `frozenset()`. Would you be interested in sending a...

> It is defined in types.py, https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-api/src/opentelemetry/util/types.py#L18, that we can supply a sequence of say strings as an attribute to a metric. This does not work with lists and sets...

> * Is it set in stone that https://github.com/open-telemetry/opentelemetry-python/blob/main/opentelemetry-api/src/opentelemetry/util/types.py#L18 should supports lists, hence this being a bug? One possible way to go would be to let the caller do the...

This was definitely a mistake > 2\. Releasing 1.23.1 with a backwards compatible fix such as (2) above. Can someone send a PR and we can try to make a...

@QuentinN42 the current CI failure "metrics/integration_test/test_console_exporter.py - TypeError: 'ABCMeta... is not subscritable" I think can be solved by quoting the type annotations

If CI is passing I think we should add it. I think @ocelotl discussed this in one SIG but don't remember the outcome of that discussion