Andrew Allen comments

Results 7 comments of


                                            Andrew Allen

another fix for #261, in extendNative, share prototype, copy direct properties (not from prototype)

Note on testing: this does seem to work back to IE9, but not IE8 (which seems irretrievably broken at this point, and doesn't even support XMLHttpRequest.DONE anyways), and does work...

another fix for #261, in extendNative, share prototype, copy direct properties (not from prototype)

Okay, it looks like @EatBreatheCode has been transferred ownership in issue #505 , but I don't know what else needs to happen in terms of release cycle and PR approvals....

another fix for #261, in extendNative, share prototype, copy direct properties (not from prototype)

@CodeByZach , yes, I think this still should be merged, as I think the issues it fixes are still present. I remerged in master and got rid of the coffeescript...

Breaks class properties of XmlHTTPRequest

I think I tracked this down to the `key` not being loop-localized in `extendNative` here: https://github.com/HubSpot/pace/blob/master/pace.coffee#L296 , so all the `XMLHttpRequests` property values end up as the value of the...

clarification on device disclosure doc of wildcard applicability to root domain

We just wanted to know if we needed to list both `quantserve.com` and `*.quantserve.com` in our JSON file, or if just the wildcard version would do, since the spec wasn't...

allow server to connect to forwarded agent from client

Okay, it looks like PR #781 was about half of what I was thinking here.

AutoComplete/Template Variables: Prometheus auto-complete and template variables can be very slow to load on large clusters

Hi @bohandley , just wanted to give this an issue an upvote, we're running into slowness during autocomplete developing on our mimir cluster, loading about 6.2k metric names and 1.6k...