Alex Ungurianu comments

Results 5 comments of


                                            Alex Ungurianu

This library should have type annotations

I'm removing the last footprints (hopefully) of python2 in #678. This will allow us to write types in the `py` files directly. Lemme know if you wanna collaborate on this.

docs: kick start the process of adding type definitions

I think I agree. I've just been adding any new modules inside the `TYPE_CHECKING` check, but adding all imports used for typing and repeating module imports makes sense.

docs: kick start the process of adding type definitions

This is ready for a proper review now. The history log in the PR is a bit of a mess for this due to me fighting with Hound and with...

docs: kick start the process of adding type definitions

I'm considering declaring bankruptcy on this PR and re-openning so that it looks a bit more approachable for review. Also, if there's anything in the structure that makes it hard...

Gate PR's so they require CI checks to pass

I agree with this, but I feel like fixing/ignoring the intermittent tests is a pre requisite for this