Anthony Stewart

Results 15 comments of Anthony Stewart

This seems to effect any string literals inside parentheses, it seems to be fixable by adding `#string_context` before `#parameter` in the `function_parameter_context` within the json file. ![image](https://user-images.githubusercontent.com/150152/121379851-b49bca80-c944-11eb-9781-dc3fce41101a.png)

Just a follow up on this, it looks like we can still reach an error state even with the fix submitted last year. Result after existing fix: ![image](https://user-images.githubusercontent.com/150152/175947206-65c35de9-0079-44bb-b2e4-cc05e9833991.png) But we...

Sorry, I missed that you had replied. Syntax highlighting is working fine, what is missing is bracket matching. I think to get bracket matching to work, you have to specify...

It also effects vscode.dev which runs in the browser rather than electron? So I guess it is an issue with newer versions of Chromium.

Hi, Sorry, yes this is an issue with the grammar, not with the language server. In particular: ``` "type-annotation": { "match": "(?|(?[]))+", ``` The problem is that it does not...

I have created a PR for a small patch which slightly improves things by not including parameters if there is a quote. This won't help with the issue fully though,...

The PR doesn't solve the issue completely - I think that type annotations which include a string will not be tokenised correctly.

> I've been thinking about this a lot. Without the error message the style of the invalid filed doesn't differ enough from the valid one. Yeah - that makes sense...

I've shared some WIP code just to give an idea of what I was thinking code wise - I haven't tested this version of the code yet as the version...

Created https://github.com/microsoft/vscode/pull/248133 to fallback to Linux fonts instead. I didn't see any obvious similar situations from a quick check. Created https://github.com/microsoft/vscode/issues/247766 to update the user agent detecting for Linux to...