Johan A. Holm
Johan A. Holm
Thanks for this contribution! Adding support for `HF_ENDPOINT` in `load_file_from_url` is a useful feature, especially for users behind mirrors or in restricted environments. The core change in `modules/util.py` correctly implements...
@licyk alright, I just misunderstood the code then.
The PR description mentions "optimized loops," but I couldn't find any changes related to loop optimization in the diff. Could you clarify which loops were intended to be optimized or...
I recommend moving the `test_dataframe_mode` function and its associated imports from `dask/tests/test_core.py` to a more appropriate file within the `dask/dataframe/tests/` directory (e.g., `dask/dataframe/tests/test_dataframe.py` or potentially a new `test_reductions.py` if suitable)....
LGTM. Reason: The proposed change is a well-justified bug fix that directly addresses the issue described in the pull request. It correctly replaces a too-specific type check with a more...
LGTM! This looks like a good fix for the issue described in #59350. The changes in `pandas/core/groupby/grouper.py` directly address the scenario where an out-of-order index could cause misalignment when resampling...
This looks like a good job. However, I noticed some conditional logic added in `frame.py` (`_cmp_method`, `_arith_method`, `_construct_result`) and `series.py` (`_construct_result`): ```python if not getattr(self, "attrs", None) and getattr(other, "attrs",...
LGTM! This PR effectively adds the new Image-to-Video block using FAL AI as described. The implementation aligns well with the project structure, handles credentials securely, and includes a robust polling...
I found a potential issue. @nissa-seru The goal of making the decorators no-op for abstract methods to support type variables in signatures is a good one. However, I believe the...
Just a note. The PR description mentions creating a method named `get_full_precision_tree_splits`, but the implemented function is named `get_full_precision_splits`.