Allan Feldman

PGP key import fails when using "export-secret-subkeys" on v0.6.0

25

On version 0.6.0 of pass, PGP key init appears to have stopped working. When trying to import keys I get an error message dialog along the lines of "cannot import...

[Performance] gRPC instrumentation: interceptor causes full payload to marshal into memory

4

[This call causes the proto to get marshalled into memory](https://github.com/open-telemetry/opentelemetry-go-contrib/blob/be89a1bdcc5b8696c914688b3c5c0e2d9e45ee84/instrumentation/google.golang.org/grpc/otelgrpc/interceptor.go#L52) Stack Trace: ``` go.opentelemetry.io/collector/model/internal/data/protogen/collector/metrics/v1.(*ExportMetricsServiceRequest).Marshal (opentelemetry-collector/model/internal/data/protogen/collector/metrics/v1/metrics_service.pb.go:238) google.golang.org/protobuf/internal/impl.legacyMarshal (google.golang.org/[email protected]/internal/impl/legacy_message.go:404) google.golang.org/protobuf/proto.MarshalOptions.size (google.golang.org/[email protected]/proto/size.go:43) google.golang.org/protobuf/proto.MarshalOptions.Size (google.golang.org/[email protected]/proto/size.go:26) google.golang.org/protobuf/proto.Size (google.golang.org/[email protected]/proto/size.go:16) github.com/golang/protobuf/proto.Size (github.com/golang/[email protected]/proto/wire.go:18) go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.messageType.Event (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected]/interceptor.go:52) go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/otelgrpc.UnaryServerInterceptor.func1 (go.opentelemetry.io/contrib/instrumentation/google.golang.org/grpc/[email protected]/interceptor.go:336) go.opentelemetry.io/collector/model/internal/data/protogen/collector/metrics/v1._MetricsService_Export_Handler...

The SDK should implement a retry strategy to handle connection errors / server errors. The retry strategy should be configurable. See the [implement-retry](https://github.com/newrelic/newrelic-telemetry-sdk-python/tree/implement-retry) branch for a proposed solution.

The common field is expected to be an instance of the telemetry type that's being sent. For example, sending a batch of `Span` means that the common field is an...