elementaryos-firefox-theme icon indicating copy to clipboard operation
elementaryos-firefox-theme copied to clipboard

MacOS layout, no buttons present when title bar is disabled

Open DeeeeLAN opened this issue 1 year ago • 6 comments

The buttons show up properly when the title bar is enabled, but they are nowhere to be found when it is disabled.

Title bar: image

No title bar: image

DeeeeLAN avatar Jul 17 '22 10:07 DeeeeLAN

Hello, I can not reproduce this issue. The titlebar should be disabled and macos should be selected in Tweaks, then you install the theme. Maybe you have installed the Titelbar Enabled version of the theme which will enable the titlebar and disables the other window control buttons.

Zonnev avatar Jul 17 '22 10:07 Zonnev

That was my original setup. I assume it is an issue with being on Arch running Pantheon instead of Elementary OS. I will dig into it further and let you know.

DeeeeLAN avatar Jul 17 '22 17:07 DeeeeLAN

@DeeeeLAN may your issue be related with #185 ? Please, try to run theme installation again and let us know the result.

sempasha avatar Jul 27 '22 10:07 sempasha

I think this is not an issue with the Titlebar Enabled theme because that theme removes the space for the window control buttons. Seeing the screenshots, the space for the buttons are there but they are empty.

I think this issue is indeed related with eOS not being native on the pc of @DeeeeLAN and therefore not showing the buttons. I've put the window control buttons display to none in base.css (line 254), this is why they are not showing in Arch but are only showing in native eOS.

I think if you want to use Arch and see the buttons, you need to remove at line 254 in base.css:

#window-controls {
    display: none !important;
}

Good luck @DeeeeLAN!

Zonnev avatar Jul 27 '22 14:07 Zonnev

Thanks for the suggestion. I tried commenting that region and restarting firefox but it didn't appear to make a difference. Something else must be hiding the window controls too.

DeeeeLAN avatar Jul 27 '22 20:07 DeeeeLAN

Maybe at line 274 you can try commenting this one too:

#TabsToolbar .titlebar-buttonbox-container {
    display: none !important;
}

Zonnev avatar Jul 27 '22 23:07 Zonnev

I close this since it seems an inactive issue.

Zonnev avatar Jan 14 '23 15:01 Zonnev