Ziad El Midaoui comments

Results 13 comments of


                                            Ziad El Midaoui

8341438: TextFlow: incorrect caretShape(), hitTest(), rangeShape() with non-empty padding/border

I tried it, the tests pass successfully however when trying in MonkeyTester I am not able to show characters and caret path when I check the box it throws an...

8330559: Trailing space not rendering correctly in TextFlow in RTL mode

> @Ziad-Mid do you think this fix is independent of ([JDK-8318095](https://bugs.openjdk.org/browse/JDK-8318095) I am checking the JDK-8318095 with more tests, but a first thought they look independant to me. I will...

8330559: Trailing space not rendering correctly in TextFlow in RTL mode

@andy-goryachev-oracle I have provided a fix for [JDK-8318095](https://bugs.openjdk.org/browse/JDK-8318095) in PR [1995](https://github.com/openjdk/jfx/pull/1995). It doesn't impact the changes in this PR as mentioned, you can review it and let me know your...

8330559: Trailing space not rendering correctly in TextFlow in RTL mode

Could you please re-review this PR

8330559: Trailing space not rendering correctly in TextFlow in RTL mode

Thank you for reviewing.

8330559: Trailing space not rendering correctly in TextFlow in RTL mode

/integrate

8358023: javafx.scene.control.ColorPicker configure size of squares in color pallet

I changed the status of the PR to draft as suggested to review the comments.

8318095: TextArea/TextFlow: wrong layout in RTL mode

Working on a JUnit Test for this bug.

8318095: TextArea/TextFlow: wrong layout in RTL mode

> Notice how the layout is still not right in some places when the window is resized (the screenshots are from a combined branch of this PR + #1988 but...

8318095: TextArea/TextFlow: wrong layout in RTL mode

> Another thing you might want to check is whether the LayoutInfo and related APIs (caretShape, etc) report correct information. There is another bug for this issue [JDK-8319050](https://bugs.openjdk.org/browse/JDK-8319050) which I'm...