Zhang Yi Jiang

Results 43 comments of Zhang Yi Jiang

Sorry, could you provide more information what DYOM modules are? I've never heard of them before.

@sciffany Sure! Since this is a relatively large change, could you sketch a rough outline about your approach before starting?

Using the module code field to indicate a module is custom is probably a bad idea. You're using a single field to store two pieces of unrelated information, and that's...

@masihtamsoy Sure! You can find instructions for setting up here: https://github.com/nusmodifications/nusmods/tree/master/www

prefetch and preload only applies to code split chunks, since those modules are packed into separate JS files when we run Webpack (you can take a look at the files...

As the docs say > This will result in `` being appended in the head of the page So you can run `yarn build` and see the results. You can...

I think this should be reported to the department of math, but it is worth adding some validation to check if year long modules are offered in both sem 1...

This is an interesting implementation of the feature request! That said, I think there are a few issues - It won't work on mobile - the buttons are extremely small...

Also, this needs to be a persisted preference - there's not much point in changing the start and end time only to find the timetable reset when you come back

In general we have a high bar for adding new settings. In this case I would strongly suggest just showing the lessons if they occur before the selected start time....