Zhang Yi Jiang

Results 43 comments of Zhang Yi Jiang

Do you mean the parent can call execute in onLoad? They absolutely can, but like I said it seems surprising that the component doesn't do this already, and it's very...

Sure, added a test case that fails on master. It's a bit weird because we need the global hcaptcha not to be defined when the component is mounted to simulate...

https://github.com/hCaptcha/react-hcaptcha/pull/91/files#diff-bfe9874d239014961b1ae4e89875a6155667db834a410aaaa2ebe3cf89820556R210 This returns `Promise` if `!isApiReady` - you would expect this to always return a promise resolving to the token, even if the API is not loaded (similar how `execute()`...

No that's not quite the same issue - this is calling execute before load, that is calling execute on load. That said, since #91 is merged, this also needs to...

Peer dependency means that the library can be installed with future versions of React, and npm or yarn will only emit a warning if the peer dependency is not met....

This also happens on the page on enums: https://www.typescriptlang.org/docs/handbook/enums.html#computed-and-constant-members ![screenshot from 2018-05-11 10-09-45](https://user-images.githubusercontent.com/445650/39902998-71b68bd2-5503-11e8-8fd2-246c03410a0f.png)

To elaborate, the [correct MySQL syntax](http://dev.mysql.com/doc/refman/5.6/en/delete.html) for deleting from a single table is ``` DELETE FROM `table_name` WHERE row = value ``` Whereas the code currently only seems to produce...

For 1: This would make the library compatible with the many libraries that use the ReadableStream interface instead of the concrete class - https://github.com/DefinitelyTyped/DefinitelyTyped/search?q=readablestream&unscoped_q=readablestream (a bit arbitrary, but it's a...

@aaditkamat Yeah, absolutely! Sorry I didn't notice this earlier. You don't need our permission to start on any of these issues :)