Nico Franke comments

Results 16 comments of


                                            Nico Franke

Animations

Is there any progress on that? I would really love to see those rating animations

> In case it helps anyone else, an adaptation of this worked for me: [nestjs/docs.nestjs.com#394 (comment)](https://github.com/nestjs/docs.nestjs.com/issues/394#issuecomment-582161405) Do you possibly still have that code around and could share it?

Export component prop types

> I have been doing React.ComponentProps for exactly the same use case (I wrap all the components I import) and it worked very well so far! However v1.6.0 breaks this...

Fix callback being called after dropping the stream

When I think about it this might not be the best solution because StreamInner is still alive after dropping Stream

Fix callback being called after dropping the stream

Now uses a weak reference to allow the inner stream to drop

Fix callback being called after dropping the stream

Hey @est31, sorry to bother. Do you think we could get this merged soon or is there anything left to do? It's a pretty major bug on MacOS

Stream dropped but audio callback still being called

I can confirm, it happens in for me too on `0.15`, it doesn't happen on `0.14` or when using the default input device on `0.15`. I only tested on macOS...

Stream dropped but audio callback still being called

After some testing I found out that 0af6a1c is the commit that introduced the bug.

Stream dropped but audio callback still being called

Could be only on MacOS. I only tried it there

Stream dropped but audio callback still being called

I think I might have an idea, why this does not work. Because stream_inner is actually kept alive inside the callback of the disconnect listener (AudioObjectPropertyListener) the drop on it...