Zen van Riel comments

Results 6 comments of


                                            Zen van Riel

Recommended "--omit=dev" option not found for NPM 8

I was on NPM 8.5.0 and did not receive this warning. Upgraded to 8.13.2 and now I get it as well. Seems to be a new warning (nowadays the --omit=dev...

feat: handle entire CORS process (preflight handling)

I agree that it would be nice to have an intuitive solution. Luckily, it is possible to handle preflight as follows within the `createExpressServer` options (this solution works for Express):...

Refer to mysql2 instead of mysql for Node.js

Seems like GitHub mobile got rid of the initial document details 🤔

Refer to mysql2 instead of mysql for Node.js

FYI it's not like mysql is broken but after playing around with it this seems heavily outdated. For example mysql does not support promises and mysql2 does 😄

Change ThreadLock to ThreadRLock to resolve rare deadlock

@tomchristie Is the team aware of this PR? I'd love to get an opinion on this PR because we still see this issue pop up. (https://github.com/encode/httpcore/discussions/990)

Change ThreadLock to ThreadRLock to resolve rare deadlock

> I tested it, and this pull request doesn't seem to work for #1029 ? Could be, the issue we experience is not really related to large files so your...