Ali Sherief

Results 26 comments of Ali Sherief

In the `Simple` section: > A ''simple'' signature consists of a witness stack, consensus encoded as a vector of vectors of bytes, and base64-encoded. I think it should be made...

It's actually not even necessary to change the behavior of OP_CHECKSIG in this context. It will already hash all inputs, outputs etc. so these can be used in message signatures...

> Hi, thanks for the PR. > > The reason why CI doesn't like this is that the files `precomputed_ecmult[_gen].c` are generated via `precompute_ecmult[_gen].c`. You'll also need to change the...

> My inclination is that they should be beside the options themselves, maybe with some sentinel like `BUILD-DEFINE:` that the README would tell people to grep for. If the docs...

> I still lean towards what I suggested in [#1113 (comment)](https://github.com/bitcoin-core/secp256k1/pull/1113#issuecomment-1171307979): A table in the README, or maybe in a file referenced from the README, that has a row for...

@real-or-random Config options have been added to the README.

Also, do you think that the `./configure` docs should be trimmed, considering they are a duplicate of the README?

This might be obvious but also check that your font was not set to a white color by accident by some framework - in that case the fonts are actually...

It seems that the chain codes used for calculating the child keys are completely wrong - it does HMAC on the mnemonic words themselves instead of the 128-bit seed entropy...

I fixed this in my fork of Pywallet: https://github.com/ZenulAbidin/zpywallet