Trevor James Smith
Trevor James Smith
I'm not trained in ocean indices, but I'll help wherever I can.
Here's another such example: * https://github.com/Ouranosinc/xclim/blob/798c036a1022e8e1ad70cc98bba3a69144719aa4/xclim/indices/_multivariate.py#L564 * https://github.com/Ouranosinc/xclim/blob/798c036a1022e8e1ad70cc98bba3a69144719aa4/xclim/indices/generic.py#L657 I suppose in this case, we could offer both, seeing as the `_multrivariate` version has units checking, but we could also just...
Interesting. This is certainly a bit confusing (I wasn't sure what the difference was at first glance). It might be good to add a `Warning` to these, or maybe better...
Ouch. That happens. Open an issue about it for reference?
@bzah Thanks for those. We haven't advanced on this yet, as we want to reach something feature-complete first, with a stable API. I think (hope) we'll be working on this...
Let's discuss this in the meeting.
@aulemahal What degree of complexity should we be considering here?
To follow up on this, if we want to base some work off of https://github.com/Ouranosinc/xclim/blob/e98de81a97f710fded9d9a6841119261fac9f30c/xclim/core/dataflags.py#L572 (or even refactor that sub-function to `utils.py`), that might help us along.
Marking this as a `wontfix` for now, since the changes need to be performed upstream in our dependency stack.
This is definitely a good idea and it would make it much easier to port the maintenance gains in xclim to other services/libraries we build. Alternatively, we could try configuring...