Martijn van der Ven

Results 145 comments of Martijn van der Ven

> Let me know if you'd accept a PR. For now: no. (Unless @Nyholm over-rules me.) There was a PR for this already, #98, but it was closed by its...

It only works if you do not declare strict types and allow PHP to do the silent casting. If you use `declare(strict_types=1);` like we do for every class implemented in...

Can you help me create a minimal test case reproducing this? I am not sure I fully understand what dependencies I all need to get the test code you are...

I am not sure what the expected behaviour is here. PSR-17 factories make no mention of setting a value for the query string arguments on a PSR-7 Request. PSR-7 says...

Ah, yes, if you are not actually using `Nyholm/psr7-server` then maybe my response does not make a whole lot of sense! I have now moved the issue. > Formally you...

These already exist. I have contributed to them. So has @Nyholm. But they test for strictness of the specification, and what you have here does not seem to be defined...

Thanks for bringing the discussion to attention! I have changed the title to more reflect the current idea. I definitely think it is worth looking into what other implementations have...

Yes, and I think that might be the only one PHP’s native [`serialize()`](https://secure.php.net/manual/en/function.serialize.php) is having problems with. I wonder how much information should be kept when serialising Stream objects. Is...

Just cloned latest master and I still do not pass tests locally. Actually failing two of them now: ``` $ locale LANG="" LC_COLLATE="C" LC_CTYPE="UTF-8" LC_MESSAGES="C" LC_MONETARY="C" LC_NUMERIC="C" LC_TIME="C" LC_ALL= $...

Would love to know what locale settings other people are running the tests on, to know if it is just something about me, or if PHP is way more locale...