Peter Hill

Fixes #128 Also fixes a warning when building with recent CMake about minimum required CMake version being unsupported -- this is coincidental, 3.21 is required for the `PROJECT_IS_TOP_LEVEL` built-in variable

Warnings from gcc 13.2

CI: Add basic workflow

1

Builds on Ubuntu-latest with GCC and Clang. Probably also worth adding a Windows build, although I'm not sure how best to install netcdf-C that way

Fixes #134 Main fix is to use `H5Z_FILTER_DEFLATE` instead of bzip2, as deflate should always be available. Also check the return values of `getFilter`

`file(GLOB)` is a [CMake anti-pattern](https://gist.github.com/mbinna/c61dbb39bca0e4fb7d1f73b0d66a4fd1#dont-use-fileglob-in-projects) and can cause various issues. Here it also causes `test_utilities.h` to be installed

In my recent PR #121 I made a change (b18cc3c44e4f15ec5587cec2434981239d27b31e) that requires C++11. It seems the rest of the code is written in C++98 only. Requiring at least C++11 would...

What are some useful contributions?

1

I work on several projects that all make heavy use of netCDF and I'd like to give back by making some contributions. Are there any particular areas where you would...

Unit tests are slow

9

The unit tests take really quite a long time to run. I used the pytest profiling extension, and it looks like creating and opening datasets takes the vast majority of...

Animations are a little tricky to use at the minute. I'm just dumping some info here, I'll try and fix some of these myself next week. I get this warning...