Peter Hill

Results 535 comments of Peter Hill

This is something we should consider when thinking about the `Solver`/`PhysicsModel` interface going forward.

I do think case-sensitive `Options` should be considered, though I would be more keen on it if we had a better way of dealing with unused/unknown/mistyped options. If we didn't...

Ok, I will make a separate PR with modifications to case sensitivity: - remove case insensitivity (breaking change) - add `strict` (or better: `input:strict`?) option, defaulting to `true`, which checks...

Yes, good idea! I'd really love for `./mymodel --help` to list all the possible options, but I think that would require a massive overhaul of how we used options. It...

Oh yes, that's probably good enough. Maybe just print it to screen, to avoid clobbering an existing BOUT.settings file?

This is almost ready to remove the `bout::globals::dump` instance, as well all of `Datafile` and its implementations. There are (at least!) two remaining sticking points: 1. `LaplaceNaulin` and `LaplaceIPT` have...

I need to write some docs on all the changes, so not really ready to be merged, but otherwise the code is ready for review. This is a pretty big...

Failing test is clang-tidy-review because there's a bug in clang-tidy that makes it choke on `LaplaceIPT` for some reason.

One of the things I don't especially like about the design here is the `outputVars` method that is now in lots of places: 1. the name isn't great, I chose...

Some timing information from blob2d, run on 16 cores, averaged over three runs (all the numbers have been averaged, I've not recalculated the "% of top" or "Mean time" columns...