Liu Zhiheng

can use ButtonBuilder

> > can use ButtonBuilder > > At least in the button builder couldn't you add an Icon as an optional parameter? No one really uses icon data. Also, it...

I put it like ``` SignInButton( this.button, { ``` because button field cannot be omitted. Is there a reason to use it as an optional field?

I remove splash color on Google button because the logo is a image, and the splash looks a bit weird to me when it doesn't apply to the logo.

Thx, but this PR doesn't align with google [Sign-In Branding Guidelines](https://developers.google.com/identity/branding-guidelines)

looks like it does not really *disable* the button (not clickable)

It's indeed a good usecase, will consider adding a disable flag in next release.

That's a reasonable request, but it will be a breaking change to previous versions. If you need to use this feature, I think you can fork and edit your own...

> @Umar-Khan-Yousafzai Thanks for mentioning this issue :) @ZaynJarvis can you please assign me this issue i am happy to work on that issue > > Thank you Yea sure,...

indeed, thx. will fix!