Zaggy1024
Zaggy1024
Updated to resolve all the comments so far I believe, let me know if there's anything else!
I forgot to comment again, but this should be good for another look or merge if everything looks good.
Just noticed a typo with the ColorRange enum comment, so I went and added value ranges for the comments there. I think everything should be good to go now.
@ADKaster Done.
Fixed some indentation that VSCode left in :( hopefully it passes linting now.
> Surely the LibGUI change will affect other applications? I doubt PixelPaint is the only one affected by the reversal of the order that actions and keydown events are processed?...
I did some testing and ended up fixing some issues with my implementation of this system in Window.cpp and Widget.cpp. In the process, I noticed some applications that weren't calling...
> Code looks fine to me, but I tried this out and the first thing I noticed is that the keyboard shortcuts in Terminal don't work. :^( I've added a...
> Another alternative is just to say that all shortcuts should take precedence over any terminal input, but I'm not sure what kind of implications that would have since I...
I see this on Windows 10 32-bit Nightly:  It doesn't appear that the original report had the OS specified, so perhaps this is what they were talking about?