Zac Sweers
Zac Sweers
See https://github.com/ZacSweers/CatchUp/pull/1223
See https://github.com/ZacSweers/CatchUp/pull/1223
Could be as simple renaming any existing smoke tests
https://cs.android.com/androidx/platform/frameworks/support/+/androidx-main:compose/runtime/runtime/src/commonMain/kotlin/androidx/compose/runtime/NonRestartableComposable.kt;l=19-24?q=annotation%20class%20NonRestartableComposable
This would be similar to the new `UnrememberedStateDetector` in androidx, but be a warning lint to catch likely cases. `@StateFactoryMarker` works for functions, but it doesn't help with cases where...
Proposal: Consider dropping alpha/beta releasing strategy in favor of just experimental annotations
This library currently uses a combination of experimental annotations on top of extensive alpha/beta preview release cycles. At the time of writing, there are alphas for both 1.8 _and_ 1.9...
Repro: https://github.com/slackhq/circuit/pull/1121 Version: `1.9.0-alpha-4` File: `circuitx/overlays/src/jvmTest/kotlin/com/slack/circuitx/overlays/OverlaySnapshotTests.kt` Trace: ``` java.lang.RuntimeException: Can't wrap nullptr at org.jetbrains.skia.impl.Native.(Native.jvm.kt:40) at org.jetbrains.skia.impl.Managed.(Managed.jvm.kt:12) at org.jetbrains.skia.impl.RefCnt.(RefCnt.jvm.kt:6) at org.jetbrains.skia.Image.(Image.kt:6) at org.jetbrains.skia.Surface.makeImageSnapshot(Surface.kt:762) at androidx.compose.ui.test.SkikoComposeUiTest.captureToImage(ComposeUiTest.skikoMain.kt:343) at androidx.compose.ui.test.SkikoComposeUiTest.captureToImage(ComposeUiTest.skikoMain.kt:348) at io.github.takahirom.roborazzi.RoborazziDesktopKt.captureRoboImage(RoborazziDesktop.kt:39) at io.github.takahirom.roborazzi.RoborazziDesktopKt.captureRoboImage(RoborazziDesktop.kt:23)...
Currently it's not possible to apply shape clips or elevation to the internal `AsyncImage` as the modifier on `ZoomableAsyncImage()` applies them to the whole layout
https://user-images.githubusercontent.com/1361086/226404793-ad827ad0-6ce9-4a92-93eb-ccfa47c7c3cb.mp4 Repro code: https://github.com/ZacSweers/CatchUp/pull/576