Ziggy Jonsson

Results 124 comments of Ziggy Jonsson

Can you past the exact code you ran? Did you close the writer after writing data?

What node version? It's important that you are on a version that supports `async/await`

@burgrp you will also find the proposed fix in the reference above, from Feb 1 2018

Improved tests required: should capture statistics that are different across pages and row_groups and include null_values and unique_value counts

Not ready to merge. `max_value` and `min_value` have to be encoded with the column encoding

Here is a failing branch: https://github.com/ZJONSSON/parquetjs/tree/parquet-mr-fail Problems with the RLE encoding ![image](https://user-images.githubusercontent.com/1082488/36767895-969eb2e4-1c0a-11e8-8f84-1395fe5b1a63.png)

This PR has been rebased on https://github.com/ironSource/parquetjs/pull/57 to include fixes for RLE in dlevels and rlevels + more test added to verify that the results are correct as seen from...

Do your problems go away when you use this branch? The only outstanding thing here is a code review afaik.

Appending to a parquet file is a little more complicated than specifying append flag on the file, as the file has a metadata and footer at the end of the...

I agree that concurrency should not be infinite. However I think there are better ways to control it than hard-coding sequential executing for tasks that could be in parallel One...