ZENOTME

Results 141 comments of ZENOTME

I realize that in future we need to add position delete file writer, and the user can use like following (use different writer seperately): ``` // Create a writer to...

https://iceberg.apache.org/spec/#partitioning:~:text=Partition%20data%20tuple%2C%20schema%20based%20on%20the%20partition%20spec%20output%20using%20partition%20field%20ids%20for%20the%20struct%20field%20ids This should do after we support partition in data file, I find that this sumary is computed from the partiton in data file.

BTW, do we prepare to support partition in 0.1 veriosn? It seems the whole API can build without partition.

There are two problem in https://crates.io/crates/ordered-float 1. -0 == +0 2. it don't have concept of -nan I guess the only solve way is to maintain our own ordered_float.

> Maybe it's easier to implement Hash and Eq by our own. Do you means that implement the custom behaviour in PrimitiveValue🤔, like ``` impl Ord for PrimitiveValue { fn...

I think not yet. Let's address it during the v0.1 polishing stage.

There is also probability that cardinality of range only partition be ten thousands. E.g. the partition is `year, month,day,hour`.🤣 But the probability of this may be not high and we...

> Thanks [@ZENOTME](https://github.com/ZENOTME) for raising this. The core part of commit of conflict detection for different isolation levels, which is quite hard to implement correctly. Retry itself is not a...

Hi, I take some time to figure out the whole commit process. The whole commit phase can be described as follows: 1. load current metadata from the catalog 2. create...