Yuriy Velichko
Yuriy Velichko
Hi @jono, @bretg, sorry, I remember that I promised to take a look at this ticket and provide implementation spec, but unfortunately, I didn't have the bandwidth. I'll do my...
Hi @bretg, @jsligh, ## Investigation I've been experimenting with the current implementation and we can adapt it if we don't want to work on the internal-model level. The current method...
Totally agree with @bret! The issue and fix look relevant to SDK. Moreover, the provided fix will silently break the current behavior. Also. @AbrahamArmasCordero , please share the code snippets...
@AbrahamArmasCordero, thanks for the details and the requests. If it's necessary to send these keys from the SDK the fix should be a bit different. If the publisher didn't provide...
> @YuriyVelichkoPI done both PR's hope this works, if anything happens tell me. Haven't reviewed it precisely yet, but please add Unit Tests. They will help not to break the...
@bretg functions are not new. But they work incorrectly right now. And yes, once the arbitrary openrtb feature works it should be used in most cases.
As for me the PRs make sense because they fix behaviour of these properties. Right now, properties work incorrectly an publisher can't send a `false` value. So, adding tests will...
No default values in the requests. For sure.
No worries, thanks for your contribution @AbrahamArmasCordero !
Closing it since the functionality is avaliable via seting dirrect RTB request