prebid-mobile-android icon indicating copy to clipboard operation
prebid-mobile-android copied to clipboard

Not setting includewinners and includebidderkey flags to false for the request to PBS

Open AbrahamArmasCordero opened this issue 7 months ago • 15 comments

Describe the bug

Even though we are not sending the includebidderkeys and sending includewinners=true the testing prebid server is assuming that the flag is true and sending the key-values like we are using a Send All Bids workflow, so for solving this issue and having only the key-values needed for Send Top Bid Workflow is specifying either true or false is necessary.

This will also enable the PBS to implement any default value.

To Reproduce Steps to reproduce the behavior:

  1. Use the Kotlin Demo
  2. Set the flags before initialize method like so ->
PrebidMobile.setIncludeWinnersFlag(true)
PrebidMobile.setIncludeBidderKeysFlag(false)
  1. Use any GAM Original integration test Case
  2. see error

Expected behavior if we have includewinners=true and no includebidderkeys is present in the skeleton request sent to PBS we are suppose to get a Send Top Bid key-values but instead we are getting a Send All Bids key values.

Screenshots With postman i was able to showcase this -> Im setting up a Post HTTP Call with the url https://prebid-server-test-j.prebid.org/openrtb2/auction and copy pasting the logged request from prebid from the logcat

Request with only includewinners set explicitly to true image

Response with only includewinners set explicitly to true image

Request with flags set explicitly to true and false image

Response with flags set explicitly to true and false (only top bid key-values are received) image

Desktop (please complete the following information):

  • OS: Windows
  • Browser Chrome
  • Version [e.g. 22]

Smartphone (please complete the following information):

  • Device: Android Pixel 7a
  • OS: Android 13
  • Browser stock browser
  • Version [e.g. 22]

Additional context Add any other context about the problem here.

AbrahamArmasCordero avatar Jul 09 '24 09:07 AbrahamArmasCordero