Motov Yurii
Motov Yurii
@stickM4N, could you please clarify why this should be treated as breaking change? Apart from that, should we add a test for new parameter?
Since we still support `regex` parameter and just add alias (`pattern`) and make it working with Pydantic V2, I wouldn't call these changes braking. So, I would remove the mention...
> I would like to propose the following change: > ```py > def Field(default, *, ..., **schema_extra) > ``` I think this should be done in a separate PR. And...
> Regarding this, I would still label it as breaking because pydantic.v2 does not support the keyarg and will raise an error if provided. You can check the [docs](https://docs.pydantic.dev/latest/errors/usage_errors/#removed-kwargs) and...
> No, it will break now, after migrating from `pydantic.v1` to `pydantic.v2` without changing parameters from `Field(...)`. This PR will provide a solution for that rather than create an incompatibility....
Tests currently fail because new Pydantic version has been released and caused linting errors. See: https://github.com/fastapi/sqlmodel/pull/1591
Thanks! I think we should wait for #1035 to be reviewed by Sebastian and merged, then reflect those changes in this PR. So, let's wait a bit
Let's wait for Sebastian to review this. Meanwhile, community feedback about whether we need `--reload-delay`, `--reload-include`, and `--reload-exclude` is welcome
MyPy dropped support of Python 3.8 since V 1.15 (https://mypy.readthedocs.io/en/stable/changelog.html#drop-support-for-python-3-8). Should we consider upgrading MyPy to V 1.14?
#13694 contains the test case from this PR and approaches to solve the issue. Let's close this PR in favor of #13694. @RB387, thank you for your efforts!