fastapi-cli icon indicating copy to clipboard operation
fastapi-cli copied to clipboard

✨ Add `--reload-dir` option

Open JoelYoung01 opened this issue 10 months ago • 10 comments

Added the ability to pass reload-dir option to uvicorn run command.

JoelYoung01 avatar Feb 28 '25 16:02 JoelYoung01

Looks like I can't add labels. Figured maybe the autolabeler read the emojis lol, that would be neat.

Everything else should be fine, just need a label to be added.

JoelYoung01 avatar Feb 28 '25 17:02 JoelYoung01

thats not it https://github.com/fastapi/fastapi-cli/pull/36 i even tried to fix auto labeler.. with no luck

07pepa avatar Mar 07 '25 08:03 07pepa

Womp womp for us I guess haha.

Guessing @tiangolo has to add labels himself (or anyone with accesss I suppose)

JoelYoung01 avatar Mar 08 '25 15:03 JoelYoung01

Just wanna say it'd be awesome if this got merged in! I was thinking about writing a PR to do exactly this, then I saw it was already done :)

jordan-vastag avatar Apr 07 '25 19:04 jordan-vastag

Revisiting this PR to see if anything has changed.

Just to make sure I'm not blind or something I tried adding labels via the gh cli, got this error:

gh pr edit 160 --add-label feature
GraphQL: JoelYoung01 does not have the correct permissions to execute `AddLabelsToLabelable` (addLabelsToLabelable)

Would love to see this merged!

JoelYoung01 avatar Aug 12 '25 03:08 JoelYoung01

This pull request has a merge conflict that needs to be resolved.

github-actions[bot] avatar Sep 05 '25 08:09 github-actions[bot]

This is really needed. Would be great if this could be merged!

s-bose avatar Sep 10 '25 08:09 s-bose

Money

JoelYoung01 avatar Sep 23 '25 21:09 JoelYoung01

Sure! I can do that in a couple hours when I am back home, if you want! Or you can just send it too!

JoelYoung01 avatar Sep 23 '25 21:09 JoelYoung01

Let's wait for Sebastian to review this. Meanwhile, community feedback about whether we need --reload-delay, --reload-include, and --reload-exclude is welcome

YuriiMotov avatar Sep 23 '25 21:09 YuriiMotov