Niklas

Results 66 comments of Niklas

I don't understand the miri failure, but this has better lifetimes and the integration test should work. I'm still not happy about having to touch so much code.

[Using `AsMut`](https://lab.whitequark.org/notes/2016-12-13/abstracting-over-mutability-in-rust/) might help with not-carrying-`mut`-through-the-whole-code, but I'm unsure whether this would look any better.

I think this looks better, though I'm not sure combining `EFIMemoryAreaIter` and `EFIMemoryAreaIterMut` is the way to go. (Combining `TagIter` and `TagIterMut` didn't work because there's pointers in them.)

That `unnecessary pub(self)` wasn't introduced by this pull request.

Oh, great! (Don't mind me, this is just a rebase.)

Yeah sure, take your time. I think this is the simplest change I can come up with right now, but if you find a simpler one, that'd be great.

Hm, I've been trying to port this over to the new design, but I'm currently stuck with quite a lot of duplications (`BytesRefMut`, `TagIterMut`, and about half of the functions...

Thanks for the input and pointing me to the diagrams! They make the two stages of parsing clearer, but I didn't fully grasp the last one, yet. In any case,...

This would be really cool to have, but it doesn't actually work, does it? I tried your `main` branch because seems to be newer and the build fails because serde...