smbios-lib icon indicating copy to clipboard operation
smbios-lib copied to clipboard

Add no_std compatibility and x86_64 crate helper

Open alesharik opened this issue 4 years ago • 10 comments

This PR:

  • Adds no_std compatibility to this library
  • Adds method to find smbios entry in raw memory using x86_64 crate

alesharik avatar Aug 12 '21 18:08 alesharik

This would be really cool to have, but it doesn't actually work, does it? I tried your main branch because seems to be newer and the build fails because serde still gets built with the std feature.

Edit: Oh, the master branch works. Sorry about that. So, it would be great if this could be merged.

YtvwlD avatar Mar 28 '23 15:03 YtvwlD

This would be really cool to have, but it doesn't actually work, does it? I tried your main branch because seems to be newer and the build fails because serde still gets built with the std feature.

Edit: Oh, the master branch works. Sorry about that. So, it would be great if this could be merged.

Oh cool. I think we need to bring it to the master branch. @jrgerber, it feels like we need to help here. Let me know how we can proceed.

jczuluag avatar Mar 28 '23 21:03 jczuluag

Ah, great. By the way: I think it's more common to name the feature std and make it default instead of naming it no_std.

YtvwlD avatar Mar 28 '23 22:03 YtvwlD

Ah, great. By the way: I think it's more common to name the feature std and make it default instead of naming it no_std.

hmm, it is more like a no_std way, since it tries to avoid using the std crate. Just a heads up: I've been trying to merge with the current main branch, but there are a lot of issue with this fork/branch, given the fact that there is a lot of functionality that depends on std crate. So it is not building for all the cases unfortunately. More work is required in order to be integrated fully.

jczuluag avatar Apr 03 '23 14:04 jczuluag

Ok, I've just used the EntryPoints. They seem to work.

YtvwlD avatar Apr 16 '23 19:04 YtvwlD

It breaks with QEMU 8.1, sadly, because it uses SMBIOS3 and https://github.com/jrgerber/smbios-lib/commit/812920b9a80035c8c6976812a1a6c8269d52d3b8 isn't in here.

#105 sadly doesn't work with no_std, because there are still tons on std references.

YtvwlD avatar Sep 06 '23 12:09 YtvwlD