Ihor Dutchak

Results 428 comments of Ihor Dutchak

I haven't forgot about this one, but I remember I wanted to perform some kind of optimisation, at least for one of the platforms, before merging it.

I don't think it is safe to assume `hid_close` as a thread-safe function at all. Any client code has to stop any read/write attempts before calling `hid_close`. What do I...

here is a pseudo-code, that works without issues and flexible for various use-cases: thread1: ```cpp while(!interrupted) { result = hid_read_timeout(dev, buffer, buffer_size, 1000); if (result == 0) // no data...

@todbot I see that there is a good bit of discussion under [node-hid](https://github.com/node-hid/node-hid/issues/230). I'm not sure what is the node-hid implementation/use-case and don't want to misunderstand the discussion. I'd very...

> deals with this more gracefully I believe it cannot deal gracefully by design. I've checked both hidraw and macOS implementations: there is always a _race condition_ when `hid_close` is...

We could have an inline wrapper `hid_init` over `hidapi_hid_init` That would make it source compatible with all projects To keep binary compatibility - maybe enable `hidapi_hid_init` and its wrapper only,...

Maybe update `openbsd.yml` to use CMake? And discard all other changes? Good example: https://github.com/libusb/hidapi/pull/405/files#diff-ef559cda0093d7adff47d02ce8f101ea141f5b22845f353cc3e86ef5de2e2eca

I imagine having possible "`meson wrap install hidapi`" would be very convenient for Meson users. The question here is - what does it take on HIDAPI side to make it...

> once its in-tree, maintenance of it would be simple enough I'd say this statement is true for any modern build system. It is more about the fact that a...

> A project that uses hidapi could uses Meson's cmake module to build hidapi I would give it a shot. > But that has many limitations and bugs. Let see...