Ihor Dutchak

Results 428 comments of Ihor Dutchak

One step closer: #414 - Windows build artifact (as used with each release) is now created with Github actions.

The best what I can suggest right now - try to debug native calls (e.g. to libusb) and check its error-codes, to understand why the device cannot be opened.

> Its seems hid_open_path doesnt work under android, we need to use hid_open(vendor_id, product_id, NULL); As was pointed by @DavEat, `hid_open_path` does work as much as `hid_open`, as it uses...

> After I grant read and write permissions using 'chmod -R 777/dev/bus/usb', I can open the usb device normally, but only in the development environment with SU. Right, so I...

Actually, there is one more issue with the new implementation: no more explicit check for the buffer size. It is highly unlikely that WinAPI will report a `DEVPROP_TYPE_GUID` but `len`...

> According to the documentation Unfortunately I've personally seen cases when WinAPI didn't behave _as per documentation_. My consern stands: - when we pass a buffer that is bigger than...

> `include /tmp/libusb/android/jni/libusb.mk` I'm not familiar with `.mk` and Android build system, but I'm almost sure, that there has to be a better way specifying dependency, instead of hard-coding it.

Again, hard-coding full system-specific paths is definitely not something we should have in master. I'll have Android project to play soon, and will try to find elegant solution.

What's on to of my mind - replace `calloc` + `strcpy` with `strdup` I'll check everything closely a bit later

I'm probably going to spend some more time on this. I think it is possible to postpone initialization of the "path" variable until it is first time called (at least...