Yousuf Ansari

Results 11 comments of Yousuf Ansari

> Can we get before/after screenshots or videos? Sure! I’ll add before/after screenshots of the legend overlap issue (current behaviour vs this change) once I push the updated implementation.

> Looks like there's a lot of stuff being removed/disabled here that would be considered breaking changes. Thanks a lot for the detailed review, this is very helpful. I agree...

Update: - I’ve added a short before/after demo video to clearly show what this PR fixes. Before (current behavior): - Legends with many series overflow outside the chart area -...

Thanks for the review, @rusackas! 1.)Just to clarify the concern about the All/Inv buttons, they were not removed and still work as expected with the scroll legend. I’ve added a...

Hi @rusackas, I’ve pushed the final updates: • Applied the `LegendComponentOption` type fix • Updated the corresponding unit tests • Verified Scroll legends still work correctly with All/Inv selectors •...

Thanks a lot for the thoughtful review, @rusackas really appreciate the clarity on these points! You're absolutely right about the `selected: undefined` field. I removed it during cleanup thinking it...

Hey @rusackas!, I’ve pushed an update: • Restored selected: undefined in expectedThemeProps. • Switched the legend tests back to strict toEqual assertions. • Kept selector / selectorLabel and the All/Inv...

Thanks Evan! The latest CI run has passed, the only red checks are the older runs that GitHub auto-cancelled when the workflow was re-triggered. Everything else is green. Let me...

Evan, CI is all green now! 🎉 Let me know if you'd like any other tweaks.

Hey Evan! Just resurfacing this in case the earlier notification got buried, the CI is all green now. Let me know if anything else is needed.