Youssef Victor

The package size is too large, consider looking into its content to see if there is anything redundant or ways to reduce its size.

See https://github.com/dotnet/docs/pull/21559#discussion_r523422533 and https://github.com/dotnet/docs/pull/21664

Support BlockStructure endpoint for VB

1

See https://github.com/OmniSharp/omnisharp-roslyn/issues/2090 Let me know if you want me to proceed with more work supporting VB. If incomplete work shouldn't go to master, you may consider creating a feature branch...

Currently, there are code actions that are not directly `CodeFixProvider`s or `CodeRefactoringProvider`s. They are: - Suppress a diagnostic - Configure severity - Configure code-style option These need to be special...

Samples are using netcoreapp2.0 which is out of support

1

- samples/VisualBasic/APISamples/APISamples.VisualBasic.UnitTests.vbproj - samples/CSharp/APISamples/APISamples.CSharp.UnitTests.csproj - samples/CSharp/ConsoleClassifier/ConsoleClassifier.CSharp.csproj - samples/Shared/UnitTestFramework/Roslyn.UnitTestFramework.csproj - samples/CSharp/ConvertToConditional/ConvertToConditional.Test/ConvertToConditional.CSharp.UnitTests.csproj - samples/CSharp/CSharpToVisualBasicConverter/CSharpToVisualBasicConverter.Test/CSharpToVisualBasicConverter.UnitTests.csproj - samples/CSharp/Analyzers/Analyzers.Test/Analyzers.CSharp.UnitTests.csproj - samples/VisualBasic/MakeConst/MakeConst.Test/MakeConst.VisualBasic.UnitTests.vbproj - samples/VisualBasic/VisualBasicToCSharpConverter/VisualBasicToCSharpConverter.Test/VisualBasicToCSharpConverter.UnitTests.vbproj

Consider adding Roslyn component multi-targeting to templates

2

It would be very useful if the default templates have the enhanced `analyzers/dotnet` directory layout that allows multi-targeting roslyn components. See https://github.com/dotnet/sdk/pull/20793

Add source generator project template

2

There is already templates for analyzers and refactorings. I think a template for generators should also be there. https://github.com/dotnet/roslyn-sdk/tree/main/src/VisualStudio.Roslyn.SDK/Roslyn.SDK/ProjectTemplates/CSharp https://github.com/dotnet/roslyn-sdk/tree/main/src/VisualStudio.Roslyn.SDK/Roslyn.SDK/ProjectTemplates/VisualBasic It should include a unit testing project as well.

Improve exception message when VerifyCodeFixAsync(code, code) fails

2

See https://github.com/dotnet/roslyn-analyzers/pull/4700/files#r558434203

Are install/uninstall scripts needed in default analyzer templates?

3

Are install.ps1 and uninstall.ps1 needed? https://github.com/dotnet/roslyn-sdk/tree/b12057223f0b36a0bf1608418830d4675790d760/src/VisualStudio.Roslyn.SDK/Roslyn.SDK/ProjectTemplates/CSharp/Diagnostic/Package I never found myself using them. Would be better to either delete them or document the use case.

https://github.com/dotnet/roslyn-sdk/blob/master/src/Microsoft.CodeAnalysis.Testing/README.md It doesn't cover the appropriate way to test codefixes that produces multiple actions using `CodeActionIndex`.