Are install/uninstall scripts needed in default analyzer templates?

Open Youssef1313 opened this issue 4 years ago • 3 comments

Are install.ps1 and uninstall.ps1 needed?

https://github.com/dotnet/roslyn-sdk/tree/b12057223f0b36a0bf1608418830d4675790d760/src/VisualStudio.Roslyn.SDK/Roslyn.SDK/ProjectTemplates/CSharp/Diagnostic/Package

I never found myself using them. Would be better to either delete them or document the use case.

Mar 09 '21 06:03 Youssef1313

These are still used by projects that are not using <PackageReference> for NuGet.

Jun 23 '21 17:06 sharwell

Does https://docs.microsoft.com/dotnet/csharp/roslyn-sdk/tutorials/how-to-write-csharp-analyzer-code-fix sounds like a good place to document this?

Jun 23 '21 17:06 Youssef1313

It might be better to just add a one-line comment at the top of them saying they are used for NuGet package support prior to PackageReference?

Jun 23 '21 17:06 sharwell