Youssef Victor
Youssef Victor
Also the introduction of `DotNetTestPathType` doesn't look correct to me. This should be auto-detected via global.json.
https://github.com/cake-build/cake/blob/35861612192cb2fe1a47cf2a6656a9e4da80dc20/src/Cake.Common/Tools/DotNet/Test/DotNetTester.cs#L55-L101 This is all just mixing up VSTest with MTP.
To me, the first-party stuff should be handled. So, `--report-trx`, `--report-trx-filename`, `--coverage`, etc. The implementations for VSTest and MTP should also be well-separated IMO.
Note that `xunit.v3.mtp-v2` is unrelated to `--coverage`. You get `--coverage` when you have Microsoft.Testing.Extensions.CodeCoverage (first-party extension).
@mavasani Did you mean to tag me here?
Side note: this is the kind of issues that https://github.com/unoplatform/uno/issues/12187 is intending to better address. cc @jeromelaban
This could be already fixed as layouting on Wasm has changed a lot with time (the issue is dating 5 years back)
`BlameDataCollectorShouldOutputDumpFile` failed. 😕 > Assert.IsTrue failed. Dump attachment was not received.
Now, other failures after restarting the job. Likely an unintentional (but good) behavioral change of MSTest, which is also a bit unfortunate for the case of this repo specifically. There...
We need to set `ConsiderEmptyDataSourceAsInconclusive` in runsettings.